Cancel pending permission requests before the stop-button early return#197
Open
leonidasbarkas98-cpu wants to merge 1 commit into
Open
Conversation
_stopClaudeProcess clears _currentClaudeProcess synchronously, so by the time the killed process emits close/error, the early-return guard in both handlers already trips and _cancelPendingPermissionRequests never runs, leaving permission prompts stuck. Move the cancel call above the guard in both handlers so it always runs when the process goes away (Gitea issue andrepimenta#3; upstream andrepimenta#181). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process
close/errorhandlers,_cancelPendingPermissionRequests()was placed after theif (!this._currentClaudeProcess) return;guard. After pressing Stop, the process reference is already cleared, so pending permission requests were never cancelled and stayed stuck in the UI forever.This moves the cancellation before the early return. Related to the reliability reports in #178, #165, #115 and the analysis in PR #181.
🤖 Generated with Claude Code