Add conversation history deletion (single entry + clear all)#200
Open
leonidasbarkas98-cpu wants to merge 2 commits into
Open
Add conversation history deletion (single entry + clear all)#200leonidasbarkas98-cpu wants to merge 2 commits into
leonidasbarkas98-cpu wants to merge 2 commits into
Conversation
Native modal confirmation dialogs run in the extension host (webview confirm() does not work), then remove the conversation file(s) and prune the workspace-state index before re-sending the refreshed list. Upstream requests: andrepimenta#39, andrepimenta#141, andrepimenta#172. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…heck) Use the data-filename + escapeHtml pattern from plugins-script.ts and skills-script.ts instead of interpolating conv.filename directly into the inline onclick handler. Add a whitelist guard in _deleteConversation so a filename must equal its own path.basename() and exist in the current conversation index before any file is touched, instead of relying implicitly on the sanitization applied when the file was first written. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a delete button per history entry and a "Clear All" action. Confirmation uses
vscode.window.showWarningMessage({ modal: true })sinceconfirm()is unavailable in webviews. Filenames are escaped and validated against the conversations directory (whitelist check) before deletion.Fixes #39
Fixes #141
Fixes #172
🤖 Generated with Claude Code