Skip to content

Additional malformed extension testing #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 25, 2026
Merged

Additional malformed extension testing #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/kotlin/testing/Certs.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,19 @@ object CertLists {
)
}

/* A chain that has a malformed key size (OCTET STRING instead of INTEGER). */
val invalidKeySize by lazy {
listOf(
generateValidLeafCertWithAppendedTag(
KeyMintTag.KEY_SIZE.value,
DEROctetString("not an int".toByteArray()),
),
certFactory.factoryAttestation,
certFactory.factoryIntermediate,
certFactory.root,
)
}

/* A chain where the key tags are out of order. */
val unorderedTags by lazy {
listOf(
Expand Down
27 changes: 24 additions & 3 deletions src/test/kotlin/VerifierTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ class VerifierTest {
assertThat(result.cause.reason).isEqualTo(KeyAttestationReason.UNKNOWN_TAG_NUMBER)
}

@Test
fun unparseableExtension_extensionParsingFailure() {
val result = assertIs<ExtensionParsingFailure>(verifier.verify(CertLists.unparseableExtension))
assertThat(result.cause.reason).isNull()
}

@Test
fun targetMissingAttestationExtension_givesTargetMissingAttestationExtensionReason() {
val result = assertIs<PathValidationFailure>(verifier.verify(CertLists.missingExtension))
Expand Down Expand Up @@ -413,7 +419,7 @@ class VerifierTest {
}

@Test
fun verifyAsync_failure_inputChainLogged() = runBlocking {
fun verifyAsync_failure_inputChainLogged(): Unit = runBlocking {
val logHook = FakeLogHook()
assertIs<VerificationResult.PathValidationFailure>(
verifier
Expand All @@ -430,7 +436,7 @@ class VerifierTest {
}

@Test
fun verifyAsync_success_keyDescriptionLogged() = runBlocking {
fun verifyAsync_success_keyDescriptionLogged(): Unit = runBlocking {
val logHook = FakeLogHook()
val chain = readCertList("blueline/sdk28/TEE_EC_NONE.pem")
assertIs<VerificationResult.Success>(verifier.verifyAsync(this, chain, log = logHook).await())
Expand All @@ -439,7 +445,7 @@ class VerifierTest {
}

@Test
fun verifyAsync_malformedPatchLevel_logsInfo() = runBlocking {
fun verifyAsync_malformedPatchLevel_logsInfo(): Unit = runBlocking {
val verifierWithTestRoot =
Verifier(
{ setOf(TrustAnchor(Certs.root, null)) },
Expand All @@ -464,6 +470,21 @@ class VerifierTest {
.contains("Non-DER encoded boolean in RootOfTrust.deviceLocked: 1")
}

@Test
fun verifyAsync_invalidKeySize_logsInfo(): Unit = runBlocking {
val verifierWithTestRoot =
Verifier(
{ setOf(TrustAnchor(Certs.root, null)) },
{ setOf<String>() },
{ FakeCalendar.DEFAULT.now() },
)
val logHook = FakeLogHook()
assertIs<VerificationResult.Success>(
verifierWithTestRoot.verifyAsync(this, CertLists.invalidKeySize, log = logHook).await()
)
assertThat(logHook.fakeVerifyRequestLog.infoMessages).isNotEmpty()
}

@Test
fun verifyAsync_longDelay_successfullyAwaitsChallengeCheck(): Unit = runBlocking {
val chain = readCertList("blueline/sdk28/TEE_EC_NONE.pem")
Expand Down
Loading