Repository navigation
Migrate Compose image optimization and scrollable grid snippets #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edward-williams-stellarelements
wants to merge
7
commits into
android:main
Choose a base branch
from
StellarElements:compose-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
84ca43d
Add code snippets for Compose state, image optimization, card, scroll…
kkuan2011 f525f27
Review fixes for the Compose state and gestures extraction
edward-williams-stellarelements dc62dd2
Drop the minimal card snippet, it belongs to the card page work
edward-williams-stellarelements 96d5bac
Back the interop snippets with real layout resources
edward-williams-stellarelements 42f8b96
Address pre-review audit findings for the Compose extraction
edward-williams-stellarelements 6b940c2
Remove the nested scroll modifiers page, migrated in #1118
edward-williams-stellarelements 87645e1
Show the trailing content lambda in the adaptive grid snippet
edward-williams-stellarelements File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
33 changes: 33 additions & 0 deletions
33
...e/snippets/src/main/java/com/example/compose/snippets/images/ImageOptimizationSnippets.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Copyright 2026 The Android Open Source Project | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.example.compose.snippets.images | ||
|
|
||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.ui.graphics.painter.Painter | ||
|
|
||
| // [START android_compose_graphics_images_optimization] | ||
| // Prefer this: | ||
| @Composable | ||
| fun MyImage(url: String) { | ||
|
|
||
| } | ||
| // Over this: | ||
| @Composable | ||
| fun MyImage(painter: Painter) { | ||
|
|
||
| } | ||
| // [END android_compose_graphics_images_optimization] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the visible snippet on DAC does not compile, let's change the visible code so that it does compile, so we should omit the exclude tags