Skip to content

Add missing Test dependency#151

Open
maedjyuk-ghoti wants to merge 1 commit intoandroid:mainfrom
maedjyuk-ghoti:master
Open

Add missing Test dependency#151
maedjyuk-ghoti wants to merge 1 commit intoandroid:mainfrom
maedjyuk-ghoti:master

Conversation

@maedjyuk-ghoti
Copy link
Copy Markdown

Added junit dependency

Added junit dependency
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@maedjyuk-ghoti
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally it should be testCompile, but as long as there would be only Android instrumentation tests (androidTest package), using androidTestCompile is enough.
And yes, this repo is missing Junit dependency :-)

Copy link
Copy Markdown
Contributor

@slinzner slinzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dazza5000
Copy link
Copy Markdown
Contributor

merge conflict

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants