Skip to content

Add travis rebased#195

Closed
hannesa2 wants to merge 2 commits intoandroid:masterfrom
hannesa2:addTravisRebased
Closed

Add travis rebased#195
hannesa2 wants to merge 2 commits intoandroid:masterfrom
hannesa2:addTravisRebased

Conversation

@hannesa2
Copy link
Copy Markdown

It's a rebase of broken #136
I did it, because there is no progress since one year.

This PR is also based on unmerged #194 when you approve #194 first I can rebase this PR again to have a smaller footprint here

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@hannesa2
Copy link
Copy Markdown
Author

I see you use https://buildkite.com and I can't view build https://buildkite.com/bazel/android-testing/builds/41
image

It looks like you need no colaboration

@hannesa2 hannesa2 closed this Oct 12, 2018
@hannesa2 hannesa2 deleted the addTravisRebased branch October 12, 2018 04:51
hannesa2 pushed a commit to hannesa2/testing-samples that referenced this pull request Nov 13, 2022
Summary:
Closes android#194
Pull Request resolved: facebook/screenshot-tests-for-android#195

Differential Revision: D10362112

Pulled By: xiphirx

fbshipit-source-id: fe8f52b85fbfb46a3ef88e06f5378844e5b8703c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants