Update SDK, gradle, and dependencies#12
Conversation
Address deprecations and align with the latest naming Add an asset for image-based lighting (IBL)
There was a problem hiding this comment.
Code Review
This pull request updates the project to Android SDK 37 and Gradle 9.5.1, alongside significant dependency version bumps for AGP, Kotlin, and XR Compose. It refactors spatial space management by moving request logic into the MainActivity and passing callbacks to UI components, while also updating adaptive layout logic to use the new isWidthAtLeastBreakpoint API. Review feedback identifies that the new breakpoint logic (840dp) changes behavior for medium-width devices compared to the previous 600dp threshold and points out that the CompactLayout branches are missing vertical scrolling modifiers required for accessibility on smaller screens.
| primaryContent = { | ||
| PrimaryCard() | ||
| }, | ||
| secondaryContent = { | ||
| SecondaryCardList() | ||
| } |
There was a problem hiding this comment.
The CompactLayout branch should include verticalScroll modifiers to ensure content remains accessible on smaller screens, matching the implementation in the ExpandedLayout branch.
primaryContent = {
PrimaryCard(
modifier = Modifier.verticalScroll(rememberScrollState())
)
},
secondaryContent = {
SecondaryCardList(
modifier = Modifier.verticalScroll(rememberScrollState())
)
}| val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint( | ||
| WindowSizeClass.WIDTH_DP_EXPANDED_LOWER_BOUND | ||
| ) |
There was a problem hiding this comment.
The breakpoint for switching between CompactLayout and ExpandedLayout has been changed from 600dp to 840dp. This causes Medium-width devices to fallback to the CompactLayout. Consider using WIDTH_DP_MEDIUM_LOWER_BOUND to preserve the original adaptive behavior.
| val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint( | |
| WindowSizeClass.WIDTH_DP_EXPANDED_LOWER_BOUND | |
| ) | |
| val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint( | |
| WindowSizeClass.WIDTH_DP_MEDIUM_LOWER_BOUND | |
| ) |
Update codelab dependencies and address deprecations and latest recommended approaches