Skip to content

Update SDK, gradle, and dependencies#12

Merged
fuentespatrick merged 1 commit into
android:mainfrom
fuentespatrick:dependency-update
May 15, 2026
Merged

Update SDK, gradle, and dependencies#12
fuentespatrick merged 1 commit into
android:mainfrom
fuentespatrick:dependency-update

Conversation

@fuentespatrick
Copy link
Copy Markdown
Contributor

Update codelab dependencies and address deprecations and latest recommended approaches

Address deprecations and align with the latest naming
Add an asset for image-based lighting (IBL)
@fuentespatrick fuentespatrick requested a review from amyZepp May 15, 2026 21:50
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to Android SDK 37 and Gradle 9.5.1, alongside significant dependency version bumps for AGP, Kotlin, and XR Compose. It refactors spatial space management by moving request logic into the MainActivity and passing callbacks to UI components, while also updating adaptive layout logic to use the new isWidthAtLeastBreakpoint API. Review feedback identifies that the new breakpoint logic (840dp) changes behavior for medium-width devices compared to the previous 600dp threshold and points out that the CompactLayout branches are missing vertical scrolling modifiers required for accessibility on smaller screens.

Comment on lines +92 to +97
primaryContent = {
PrimaryCard()
},
secondaryContent = {
SecondaryCardList()
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The CompactLayout branch should include verticalScroll modifiers to ensure content remains accessible on smaller screens, matching the implementation in the ExpandedLayout branch.

                primaryContent = {
                    PrimaryCard(
                        modifier = Modifier.verticalScroll(rememberScrollState())
                    )
                },
                secondaryContent = {
                    SecondaryCardList(
                        modifier = Modifier.verticalScroll(rememberScrollState())
                    )
                }

Comment on lines +71 to +73
val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint(
WindowSizeClass.WIDTH_DP_EXPANDED_LOWER_BOUND
)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The breakpoint for switching between CompactLayout and ExpandedLayout has been changed from 600dp to 840dp. This causes Medium-width devices to fallback to the CompactLayout. Consider using WIDTH_DP_MEDIUM_LOWER_BOUND to preserve the original adaptive behavior.

Suggested change
val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint(
WindowSizeClass.WIDTH_DP_EXPANDED_LOWER_BOUND
)
val isExpanded = windowSizeClass.isWidthAtLeastBreakpoint(
WindowSizeClass.WIDTH_DP_MEDIUM_LOWER_BOUND
)

@fuentespatrick fuentespatrick merged commit a2f761b into android:main May 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants