Add dark mode#14
Conversation
.has-background-light was removed from footer, and replaced with "$footer-background-color: $light;" in default CSS.
andyschott
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I pulled down your code, but when I try to fetch the submodules I get permission denied errors from GitHub. What do I have to do in order to pull down the submodules you added to the project?
|
I think that's what happens when trying to clone over ssh without registering ssh public key with github. I've updated the URL to https, which should avoid this problem. |
|
Hey, did you manage to get a closer look at this? |
|
Sorry, I haven't had a chance to look at it yet (been a busy few weeks). Planning on looking at it this weekend. |
|
It looks like the submodule for |
|
I did that in f767d2e above, both submodules now using https. You might need to do |
|
I'm able to get the submodules now (I haven't done much with submodules before - sorry for the confusion). I see you said that Also, I see a lot of unstaged changes in |
Yeah, that's probably the case :( I seems that I was building the docker image and running that.
That's unexpected, I don't think git even supports committing local modifications of submodules. I just did a fresh clone of my branch and I don't see any unstaged changes. Maybe you already had |
|
I've been thinking about your change, and I love the idea of supporting dark mode, but I don't like the restrictions it places on development. Did you look for other options and couldn't find anything? Would it be worth me doing some research for other options to make the development process smoother? |
|
By restrictions you mean inability to use |
Adds dark mode support, with:
@media (prefer-color-scheme)My initial attempt was to utilise CSS variables. But for that to work I'd have to rip bulma apart and replace every color value with a variable reference. So the next best thing is to compile two different versions of bulma and switch between them.
Sorry for the mess in
MaxPowerLevel.csproj, surprisingly, that was the path of least resistance to get.scssfiles compiled on Mac. Couldn't use WebCompiler because MSVS2019 doesn't support extensions, and every NuGet package I tried either didn't work or was too eager to compile every partial.sassin submodules.Almost forgot to mention: this change breaks
dotnet run, because for whatever stupid reasondotnet rundoesn't pull in files from build output dir 🤦