Skip to content
This repository was archived by the owner on Sep 25, 2022. It is now read-only.

Only add powerful engram recommendations if more than 2 below hardcap #16

Open
michaelaird wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only add powerful engram recommendations if more than 2 below hardcap #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions MaxPowerLevel/Services/AbstractRecommendations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,17 +115,20 @@ private IEnumerable<Recommendation> GetRecommendations(CharacterRecomendationInf
recommendations.Add(recommendation);
}

// If any slot is at least two power levels behind,
// a Powerful Engram would increase the max power level.
// Ignore any slots where a season pass reward can be used first.
var trailingSlots = info.Items.Where(item => info.IntPowerLevel - item.PowerLevel >= TrailingPowerLevelDifference)
.OrderBy(item => item.PowerLevel)
.Select(item => (item.Slot, 1))
.Except(seasonPassRewards, new ItemComparer());
if(trailingSlots.Any())
if (info.PowerLevel < HardCap - 2) //powerful engrams only help when more than 2 below hardcap
{
var recommendation = new Recommendation(GetDisplayString("Powerful Engrams", trailingSlots));
recommendations.Add(recommendation);
// If any slot is at least two power levels behind,
// a Powerful Engram would increase the max power level.
// Ignore any slots where a season pass reward can be used first.
var trailingSlots = info.Items.Where(item => info.IntPowerLevel - item.PowerLevel >= TrailingPowerLevelDifference)
.OrderBy(item => item.PowerLevel)
.Select(item => (item.Slot, 1))
.Except(seasonPassRewards, new ItemComparer());
if (trailingSlots.Any())
{
var recommendation = new Recommendation(GetDisplayString("Powerful Engrams", trailingSlots));
recommendations.Add(recommendation);
}
}

recommendations.AddRange(CreatePinnacleRecommendations(info.IntPowerLevel, info.Items));
Expand Down