Repository navigation
refactor(@angular/build): encapsulate library build state in BuilderState and ExecutionResult - #34355
Merged
Merged
Conversation
alan-agius4
added
action: review
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the library builder's state management by introducing a BuilderState class to encapsulate incremental compilation state, replacing the previous SingleBuildState interface. It also updates the build pipeline to use this state class, improves the efficiency of tracking modified files, and refines the diagnostic reporting mechanism. I have reviewed the suggested improvements regarding pendingCompilationFiles accumulation and the efficiency of merging sets in compileLibrary, both of which are valid and should be incorporated.
…tate and ExecutionResult Introduce `BuilderState` and `ExecutionResult` to replace `SingleBuildState`, `BuildActionResult`, `LibraryCompilationDiagnostics`, and manual `watchedCompilationFiles` parameter threading across the library builder pipeline. `BuilderState` manages incremental compilation state, watched compilation files, pending compilation modifications across aborted watch iterations, and `ExecutionResult` diagnostic collection.
alan-agius4
force-pushed
the
library-builder-state
branch
from
October 15, 2026 13:27
2aaad5e to
f68f56c
Compare
clydin
approved these changes
Oct 15, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
BuilderStateandExecutionResultto replaceSingleBuildState,BuildActionResult,LibraryCompilationDiagnostics, and manualwatchedCompilationFilesparameter threading across the library builder pipeline.BuilderStatemanages incremental compilation state, watched compilation files, pending compilation modifications across aborted watch iterations, andExecutionResultdiagnostic collection.