Repository navigation
docs(@angular/build): correct outputFile and port option descriptions - #34404
Merged
Merged
Conversation
…ions The unit-test `outputFile` description stated that the path applies only to the first reporter, but it is passed to Vitest as is and used by every configured reporter that writes to a file. The dev-server `port` description did not mention that the `PORT` environment variable takes precedence over the option.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the schema descriptions for the Angular build tools. Specifically, it clarifies that the 'PORT' environment variable takes precedence over the 'port' option in the dev-server builder, and updates the 'outputFile' description in the unit-test builder to explain how the path is utilized by multiple reporters. I have no feedback to provide.
angular-robot
Bot
added
area: docs
alan-agius4
added
target: patch
clydin
added
action: merge
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit-test
outputFiledescription stated that the path applies only to the first reporter, but it is passed to Vitest as is and used by every configured reporter that writes to a file. The dev-serverportdescription did not mention that thePORTenvironment variable takes precedence over the option.