Repository navigation
test: avoid newline-specific assertions in formatting e2e test - #34556
Merged
alan-agius4 merged 1 commit intoOct 28, 2026
Merged
Conversation
alan-agius4
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes trailing newline characters from assertions in the formatting end-to-end tests. The reviewer identified that removing these checks weakens the assertions, as they may falsely pass even if semicolons are not correctly removed by the formatters. To address this, the reviewer suggested using regular expressions that strictly assert the presence or absence of semicolons while safely supporting both LF and CRLF line endings.
devversion
approved these changes
Oct 28, 2026
Avoid hardcoding LF (`\n`) line endings in `formatting.ts` assertions so the test passes on Windows CI where CRLF (`\r\n`) line endings may be emitted.
alan-agius4
force-pushed
the
test/fix-formatting-e2e-windows
branch
from
October 28, 2026 09:46
0fc4a23 to
7c509f8
Compare
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid hardcoding LF (
\n) line endings informatting.tsassertions so the test passes on Windows CI where CRLF (\r\n) line endings may be emitted.