Skip to content

Update README.md to include Firebase Data Connect#3673

Open
maneesht wants to merge 2 commits into
angular:mainfrom
maneesht:patch-1
Open

Update README.md to include Firebase Data Connect#3673
maneesht wants to merge 2 commits into
angular:mainfrom
maneesht:patch-1

Conversation

@maneesht

@maneesht maneesht commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@armando-navarro armando-navarro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maneesht - thanks for this, and sorry it sat so long. I've recently taken over maintenance and I'm working through the PR backlog. Data Connect absolutely belongs in the README's feature table, so I'd like to get this in. Two things need fixing first:

The link target doesn't exist

docs/data-connect.md isn't in the repo, so the heading would link to a 404. Until an AngularFire-specific docs page exists, could you point it at the official Data Connect docs (https://firebase.google.com/docs/data-connect) instead? (A docs/data-connect.md in the style of the other feature pages would be even better, if you're up for it - but I won't block on that.)

The new cell lands in the wrong row

The feature table is two columns, and this inserts a third into the Cloud Firestore / Cloud Functions row, which renders a strange-looking 3rd row that can only be seen by scrolling horizontally. The last row currently has an empty slot next to Vertex AI - moving the Data Connect cell there keeps the table balanced.

Happy to take care of it

Happy to take this over and make both tweaks myself if you'd rather - just say the word. Otherwise I'll merge once they're in.

@armando-navarro

Copy link
Copy Markdown
Collaborator

Hi @maneesht, just checking in on this one.

I'd still like to get Data Connect into the README. The only things between this and merge are the two small tweaks from my review above: pointing the link at the official Data Connect docs (since docs/data-connect.md isn't in the repo yet), and moving the new cell into the empty slot next to Vertex AI so the table stays two columns.

If you have a few minutes to push those, I'll merge. If you'd rather hand it off, I'm happy to make both changes myself and get it in, just say the word. Either way works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants