Skip to content

fix(cdk/private): guard createPolicy against DOM clobbering #33410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arturovt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cdk/private): guard createPolicy against DOM clobbering #33410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/cdk/private/trusted-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,17 @@ function getPolicy(): TrustedTypePolicy | null {
if (typeof window !== 'undefined') {
const ttWindow = window as unknown as {trustedTypes?: TrustedTypePolicyFactory};
if (ttWindow.trustedTypes !== undefined) {
policy = ttWindow.trustedTypes.createPolicy('angular#components', {
createHTML: (s: string) => s,
});
try {
policy = ttWindow.trustedTypes.createPolicy('angular#components', {
createHTML: (s: string) => s,
});
} catch (error) {
// createPolicy can throw if the name is already registered, or if
// window.trustedTypes was DOM-clobbered with an HTML element before
// Angular bootstrapped. trustedHTMLFromString falls back to plain
// strings — sanitization in _setInnerHtml still runs.
console.error(error);
}
}
}
}
Expand Down
Loading