Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MapInfoWindowhides its host element withhost: {'style': 'display: none'}. This renders as an inlinestyleattribute on<map-info-window>, which is blocked by a Content Security Policy whosestyle-srcdoesn't include'unsafe-inline'. The browser reports a violation like this for every info window on the page:Fix
Remove the host style binding and set
display: noneon the host element in the constructor through CSSOM (element.style.display). CSP doesn't block CSSOM assignments, so the behavior is unchanged and the directive works under a strictstyle-src.Testing
Verified in an app running a strict CSP (
style-srcwithout'unsafe-inline'): before the change, each<map-info-window>raised a CSP violation; after it, none are raised, and the info windows still open and close normally.