Skip to content

feat(material/stepper): add a styling token for header icon shape - #33963

Open
sdedieu wants to merge 1 commit into
angular:mainfrom
sdedieu:feat/stepper-customize-header-icon-shape
Open

sdedieu wants to merge 1 commit into
angular:mainfrom
sdedieu:feat/stepper-customize-header-icon-shape

Conversation

@sdedieu

@sdedieu sdedieu commented Oct 15, 2026 •

Copy link
Copy Markdown

Fixes: #33962

@pullapprove
pullapprove Bot requested review from ok7sai and tjshiu October 15, 2026 12:48
@google-cla

google-cla Bot commented Oct 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot Bot added detected: feature PR contains a feature commit area: material/stepper labels Oct 15, 2026
@sdedieu
sdedieu force-pushed the feat/stepper-customize-header-icon-shape branch from bca5c3b to 69bba85 Compare October 15, 2026 12:56
@sdedieu
sdedieu force-pushed the feat/stepper-customize-header-icon-shape branch from 69bba85 to dc848f0 Compare October 15, 2026 13:05
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 16, 2026
@sdedieu

sdedieu commented Oct 16, 2026

Copy link
Copy Markdown
Author

Thanks for the approval @crisbeto 🙏
Regarding this, I was wondering if you have a rule or guidelines about what can be customizable and what will never be ?
To give you some context, I work at Criteo and our design system for Angular is implemented on top of Angular Material. For some components we still have to perform bad CSS overrides to achieve what our UI team is requesting. The more and more styling tokens exists, the more and more we're able to do it the right way.
I would be more than motivated to contribute as much as possible to the angular/components codebase to add as many styling tokens as we need. Just wondering if you have somewhere a document where I can see what will never be possible and share it to my UI team 🙂

@crisbeto

Copy link
Copy Markdown
Member

We don't have specific guidelines on this. Initially we set up the tokens based on what's in the Material Design spec, but since then we've been adding tokens wherever we think it makes sense.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: material/stepper detected: feature PR contains a feature commit target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(material/stepper): Add styling token for header icon shape

2 participants