refactor: decouple CardBrowserFragment from CardBrowser activity#21158
Merged
sanjaysargam merged 5 commits intoMay 29, 2026
Merged
Conversation
ShaanNarendran
commented
May 27, 2026
05d1964 to
ee3bd5b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Each commit should compile, so the test changes should be done alongside the 'test-breaking' changes to the files |
ee3bd5b to
91bc0d8
Compare
criticalAY
previously requested changes
May 27, 2026
91bc0d8 to
86b5eb8
Compare
86b5eb8 to
4fea281
Compare
4fea281 to
36cdfbd
Compare
david-allison
approved these changes
May 28, 2026
Member
david-allison
left a comment
There was a problem hiding this comment.
LGTM, assuming you tested it
sanjaysargam
requested changes
May 29, 2026
36cdfbd to
66b269f
Compare
The fragment handles MenuHost itself when useSearchView is on, or casts the host activity (checked in onAttach).
66b269f to
a8a7871
Compare
a8a7871 to
c90b501
Compare
sanjaysargam
requested changes
May 29, 2026
Member
sanjaysargam
left a comment
There was a problem hiding this comment.
Good to go. minor nitpick
sanjaysargam
approved these changes
May 29, 2026
Member
sanjaysargam
left a comment
There was a problem hiding this comment.
Here we go. @ShaanNarendran you are rocking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Finishes the decoupling for card browser fragment so it can be used outside of card browser activity.
Fixes
Approach
Moves the remaining dependent parts into the fragment itself:
How Has This Been Tested?
Compiles and builds successfully.
Checklist
Please, go through these checks before submitting the PR.