Fix #20763: Match Scheduler.answerCard with upstream Anki#21162
Fix #20763: Match Scheduler.answerCard with upstream Anki#21162vivek41-glitch wants to merge 6 commits into
Conversation
|
Cheers! Please drop the irrelevant commits and the merge commit. Prefer to have multiple commits which we can rebase onto |
|
hi @david-allison , in my terminal things get messy ,it become overcomplicated from my side . would do it from urself squashing when merging ? i will appreciate |
|
Being able to lint your code, either via our pre-commit hooks, or |
|
You changed the PR template. Please stick to the original template and fill details there |
@criticalAY Thank you for the feedback. I apologize for changing the template. I have created a new PR (#21163) with the correct code. Please review that one instead. I will close this PR. |
|
Please force push rather than creating new pull requests - it's more work for us, and we lose the conversation |
Issue
#20763 - NoSuchElementException when cardsList is empty
Root Cause
Scheduler.kt deviated from upstream by using
queuedCards.cardsList.first()Fix
Replace with
col.backend.getSchedulingStates(card.id)to match Python implementationChanges
Testing
Code matches upstream Anki at commit 5e46fc4494b428387f1d3f5c19d0ed19a089705e