refactor: extract AnkiDroidApp.instance to :common:android#21164
Open
criticalAY wants to merge 1 commit into
Open
refactor: extract AnkiDroidApp.instance to :common:android#21164criticalAY wants to merge 1 commit into
AnkiDroidApp.instance to :common:android#21164criticalAY wants to merge 1 commit into
Conversation
| fun toBundle(): Bundle = | ||
| bundleOf( | ||
| INTENT_MODEL_FILENAME to saveTempNoteType(AnkiDroidApp.instance.applicationContext, notetype), | ||
| INTENT_MODEL_FILENAME to saveTempNoteType(AnkiDroidApplication.instance.applicationContext, notetype), |
Member
There was a problem hiding this comment.
TODO: cleanup in another commit - applicationContext is not necessary, this is an Applicaton
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| // SPDX-FileCopyrightText: 2026 Ashish Yadav <mailtoashish693@gmail.com> | ||
|
|
||
| package com.ichi2.anki.common.application |
Member
There was a problem hiding this comment.
I'd use common.android unless you feel a lot will be in this class
|
|
||
| val isInitialized: Boolean | ||
| get() = ::instance.isInitialized | ||
| } |
Member
There was a problem hiding this comment.
Disagree with me here:
I'd prefer this if it were a bare appContext variable.
- AnkiDroidApplication.instance.contentResolver
+ appContext.contentResolver-
rename current usages of
appContext -
something like this
/** */
lateinit var appContext: Context
private set
object AnkiDroidApplication {
/** Sets the [appContext]. Called once from `AnkiDroidApp.onCreate()`. */
fun setApplicationInstance(app: Application) {
appContext = app
}
}
david-allison
added
the
Needs Author Reply
criticalAY
force-pushed
the
widget/appcontext
branch
from
878e3e4 to
bdfbabc
Compare
criticalAY
removed
the
Needs Author Reply
david-allison
requested changes
May 28, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
Clean out + rename the existing non-test appContext variables before the commit declaring + using the global accessor.
AnkiDroidUsageAnalytics.appContext for example has special consideration, as instance may not have been set
…idApplication Adds a top-level `appContext: Context` accessor in :common:android, set during AnkiDroidApp.onCreate() via AnkiDroidApplication.setApplicationInstance. Shared and feature-module code can now reach the Application context without depending on :AnkiDroid's AnkiDroidApp subclass.
criticalAY
force-pushed
the
widget/appcontext
branch
from
bdfbabc to
ee10d2c
Compare
david-allison
requested changes
May 29, 2026
Member
david-allison
left a comment
david-allison
left a comment
There was a problem hiding this comment.
One issue, then LGTM
The TODO is optional
Leaving this for second approval as it's a common pattern we want to get right (naming etc...) first time
| var templateChanges = ArrayList<TemplateChange>() | ||
| private set | ||
|
|
||
| // TODO: cleanup applicationContext is not necessary, this is an Application |
| } else { | ||
| Timber.w("AnkiDroid instance not set") | ||
| null | ||
| } |
Member
There was a problem hiding this comment.
AnkiDroidApplication.isInitializedI believe- I'd prefer not exposing
isInitalizedand useAnkiDroidApplication.instanceOrNull(or similarly named variables)- as a TODO/separate commit
val instanceOrNull: Context?
get() = if (::appContext.isInitialized) appContext else null
david-allison
added
Needs Author Reply
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Extract application context to :common:android, a step towards clean code and one more step closer to widget extraction
Fixes
Approach
See commit
How Has This Been Tested?
Local build and ran on Emualtor works smooth
Learning (optional, can help others)
NA
Checklist
Please, go through these checks before submitting the PR.