Redesign of all resizeable screens#21169
Open
Haz3-jolt wants to merge 2 commits into
Open
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Move all split-pane layouts (note editor, card browser, card template editor, deck picker) from layout-sw600dp to layout-w840dp, switching from smallest-width to current-width qualifier and raising the threshold to the Material 'expanded' window size class (840 dp). This prevents split panes from activating on smaller 7-8 inch tablets, especially in portrait mode, where the two panes are too narrow to be usable. Fixes ankidroid#21010
Haz3-jolt
force-pushed
the
ne-fixup
branch
2 times, most recently
from
94cc488 to
b6939ac
Compare
Contributor
|
Snapshot diff report vs
All 1 changed screenshotsPreferencesScreenshotTest
|
Collaborator
Since we have a toggle, why not disable it by default and keep the current screen size bound? Current users who like this feature would be upset if it was removed because of the new size requirement. |
Add a 'Split view' toggle under Settings > Appearance > Layout. Defaults to on. When turned off, all split panes (note editor, card browser, card template editor, deck picker) are disabled and the screens behave as single-pane regardless of display size. This gives users on large screens the option to opt out of the side-by-side layout entirely. Assisted-by: Claude Opus 4.6
Member
|
As it stands, we couldn't cherry-pick this into 2.24.1 (.1 should only contain bugfixes), could you split this PR into two:
I don't feel When we make this change, there should be justification on why we selected it, so people have context if they wish to change this value in future |
david-allison
added
the
Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
A sizable group of users have complained about the following:
Fixes
Approach
How Has This Been Tested?
Screen_recording_20260529_035826.webm
Checklist
Please, go through these checks before submitting the PR.