fix: remove unnecessary onCreate calls#21172
Queued
david-allison wants to merge 1 commit into
Queued
Conversation
super.onCreateDialog was not required, as the classes returned a custom dialog. Introduced in ae7d237 and copy-pasted. Fixes 21171 Assisted-by: Claude Opus 4.8 - investigation and fix
34b1c03 to
3ab0ea6
Compare
lukstbit
approved these changes
May 29, 2026
criticalAY
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Assisted-by: Claude Opus 4.8 - investigation and fix
Purpose / Description
super.onCreateDialogwas not required, as the classes returned a custom dialogFixes
onCreateDialogcallssuper.onCreate#21171How Has This Been Tested?
Opened 'CustomStudyDialog'
Trusting Ci
Learning
Added in ae7d237
Checklist