Skip to content

Static Redis cache - #1

Open
vossccp wants to merge 3 commits into
ankitbko:masterfrom
vossccp:master
Open

Static Redis cache#1
vossccp wants to merge 3 commits into
ankitbko:masterfrom
vossccp:master

Conversation

@vossccp

@vossccp vossccp commented Nov 28, 2016

Copy link
Copy Markdown

Hi Ankit,

The RedisStore pretended to be non-Static; I have taken the liberty to make a static implementation of the cache (in fact, it was already static before).

Also, I felt the integration to the bot framework could be simplified by just configuring the Redis Bot cache. I think, by explicitly configuring the bot cache, we can assume that the user wants to use it with the bot framework, so we can do the configuration for him.

@ankitbko

ankitbko commented Dec 5, 2016

Copy link
Copy Markdown
Owner

Hi vossccp,

Overall this is good. However the StreamWriter in Serialize method is by default buffered. That is why I had it explicitly closed. If you can fix it it would be great.

@vossccp

vossccp commented Dec 5, 2016

Copy link
Copy Markdown
Author

Yes, you are right. I was a bit confused since Dispose should close the stream. I hope, its ok for you if we just flush before returning the content

@ankitbko

Copy link
Copy Markdown
Owner

Sorry for late follow-up. The GZipStream Flush method is not implemented to flush underlying buffer as mentioned here. We need to explicitly close the stream. Just call Close on streamWriter instead of flush and it should work properly.

@vossccp

vossccp commented Feb 20, 2017

Copy link
Copy Markdown
Author

Hi there. We never really came to finish this. Hope, its now ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants