fix(relay): allow managed startup on Windows - #83
Open
abdfattahz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Windows, a managed relay writes its
Readylifecycle event and then exits before it can accept requests.appendRelayLifecycleEvent()successfully syncs the lifecycle file, but the following directory-handlefsyncfails withEPERMbecause Windows does not support syncing a read-only directory handle.This produces
Browser Control relay did not start at http://127.0.0.1:19989for every relay-backed command. Runningbrowser-control servein the foreground reaches the same lifecycle path; the underlying error is:#82 addresses the equivalent failure when persisting
sessions.json, but the relay first encounters this independent lifecycle-log sync during managed startup. Both paths need the unsupported-directory-sync handling for normal Windows operation.What Changes
EPERM,EINVAL, orENOTSUPScope
This changes only synchronous relay lifecycle logging. It does not alter lifecycle event contents, session persistence, restart coordination, extension behavior, or public APIs. It complements rather than duplicates #82.
Verification
browser-control doctor, and navigation to Example Domain succeeded.