Skip to content

Superseded: Add SayGM provider - #4625

Closed
markdavison wants to merge 1 commit into
anomalyco:devfrom
taostat:add-saygm-provider-clean
Closed

markdavison wants to merge 1 commit into
anomalyco:devfrom
taostat:add-saygm-provider-clean

Conversation

@markdavison

@markdavison markdavison commented Aug 13, 2026 •

Copy link
Copy Markdown

Superseded by #4626. The replacement starts from the final reviewed commit after the automated feedback was addressed.

@github-actions

Copy link
Copy Markdown
Contributor

Action items

  • [high] [violation] packages/core/src/sync/providers/saygm.ts:116 - Check: Incomplete SayGM pricing must retain the last reviewed cost (PR behavior and peer sync convention). Why: buildSaygmModel throws when price_range/retail ceiling is absent, so hourly saygm sync fails for the whole provider instead of keeping authored prices. The PR body claims retention, and peers (anthropic, nano-gpt, deepinfra, xai) return existing.cost when source pricing is missing. Action: If ceiling is missing, return { ...existing } (or { ...existing, cost: existing.cost }) instead of throwing; add a focused test that missing/incomplete retail ceiling preserves the authored cost.

@markdavison
markdavison force-pushed the add-saygm-provider-clean branch from 30080a3 to 64f255d Compare August 13, 2026 14:40
@github-actions

Copy link
Copy Markdown
Contributor

No actionable findings.

@github-actions github-actions Bot added the reviewer: ready Automated review found no actionable items label Aug 13, 2026
@markdavison markdavison changed the title Add SayGM provider Superseded: Add SayGM provider Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reviewer: ready Automated review found no actionable items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant