fix: time out non-SSE streams - #39516
Draft
Davide95 wants to merge 1 commit into
Draft
Conversation
🤖 Generated with [OpenCode](https://opencode.ai) (GPT-5)
github-actions
Bot
added
the
needs:compliance
Davide95
changed the title
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
Quick update: a colleague of mine played with this patched version for a while, and he confirmed that the issue is resolved for him. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #31122
Type of change
What does this PR do?
Makes the existing opt-in
chunkTimeoutwrap every streamed response body rather than onlytext/event-streamresponses. This detects stalled EventStream and other non-SSE provider streams without reintroducing the global timeout that caused false positives for slow models.How did you verify your code works?
Screenshots / recordings
N/A
Checklist
🤖 Generated with OpenCode (GPT-5)