fix(core): exclude hidden files from glob results - #48894
Open
RRiiiccckkk wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
needs:compliance
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fix and regression test address the reported issue with no unresolved review comments.
Pull request overview
Fixes glob matching so hidden files are excluded by default while preserving opt-in hidden-file support.
Changes:
- Adds a ripgrep exclusion for hidden paths.
- Adds regression coverage for top-level dotfiles.
File summaries
| File | Summary |
|---|---|
packages/opencode/test/tool/glob.test.ts |
Verifies visible files remain while hidden files are excluded. |
packages/core/src/ripgrep.ts |
Filters hidden paths when hidden matching is disabled. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #47421
Type of change
What does this PR do?
While checking the glob tool with a temporary project, I found that
**/*.tsreturned a top-level.hidden.tseven when hidden files were disabled.Ripgrep allows an explicit glob pattern to match dotfiles unless an exclusion is supplied. The glob adapter now adds
--glob=!**/.*when hidden files are disabled. Callers that passhidden: truekeep the existing behavior.The tool test covers a visible file and a dot-prefixed file and verifies that only the visible file is returned.
How did you verify your code works?
bun test test/tool/glob.test.tsfrompackages/opencode(3 passed).Screenshots / recordings
Not applicable; this change affects filesystem filtering and has no UI changes.
Checklist