refactor(opencode): extract in-process fetch helper - #48934
Open
joaocostaz7 wants to merge 2 commits into
Open
joaocostaz7 wants to merge 2 commits into
joaocostaz7 wants to merge 2 commits into
Conversation
Local `run` and `--mini` both dispatched SDK requests into Server.Default() with the same fetch wrapper. Share one helper so auth-header changes stay in one place.
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
n/a — refactor only, no linked issue.
Type of change
What does this PR do?
Local
opencode runandopencode --miniboth build an SDK client that sends requests intoServer.Default().app.fetchinstead of the network. That fetch wrapper was duplicated in two branches (fresh--minivsexecute()).This moves the wrapper into one
inProcessFetchhelper. Same behavior: lazy-load Server, attachServerAuth.header()whenOPENCODE_SERVER_PASSWORDis set.How did you verify your code works?
Ran
bun typecheckfrom the repo root (turbo, including theopencodepackage). No runtime change; the two call sites now pass the same helper they previously inlined.Screenshots / recordings
n/a — no UI change.
Checklist