Skip to content

fix(tui): roll over compact counts to M at 999,950 #48969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hotragn wants to merge 1 commit into
base: v2
Choose a base branch
from
+11 −1
Open

fix(tui): roll over compact counts to M at 999,950 #48969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/tui/src/util/locale.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ export function datetime(input: number): string {
}

export function number(num: number): string {
if (num >= 1000000) {
// 999,950 and up round to 1000.0K at one decimal place, so roll over to M there
if (num >= 999950) {
return (num / 1000000).toFixed(1) + "M"
} else if (num >= 1000) {
return (num / 1000).toFixed(1) + "K"
Expand Down
9 changes: 9 additions & 0 deletions packages/tui/test/util/locale.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,12 @@ test("takes whole graphemes within terminal width", () => {
expect(Locale.takeWidth("ab界cd", 4)).toBe("ab界")
expect(Locale.graphemes("a👨‍👩‍👧‍👦b")).toEqual(["a", "👨‍👩‍👧‍👦", "b"])
})

test("formats compact numbers and rolls over to M at the rounding boundary", () => {
expect(Locale.number(999)).toBe("999")
expect(Locale.number(1500)).toBe("1.5K")
expect(Locale.number(999949)).toBe("999.9K")
expect(Locale.number(999950)).toBe("1.0M")
expect(Locale.number(999999)).toBe("1.0M")
expect(Locale.number(2500000)).toBe("2.5M")
})
Loading