Conversation
A configured plugin spelled `C:/x/plugins/foo` did not match the auto-discovered `C:\x\plugins\foo`, so it loaded twice, failed as a duplicate ID, and its options were dropped. Resolve absolute specs the same way relative ones already are.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48706
Type of change
What does this PR do?
Configured local plugin paths only get resolved when they start with
./or../. An absolute spec is kept as typed, soC:/Users/me/.config/opencode/plugins/foonever matches the discoveredC:\Users\me\...\footarget. The supervisor loads it twice, the second copy fails withDuplicate plugin IDand its options are lost.Absolute specs now go through
path.resolvetoo, so both spellings become the same target and the configured entry replaces the discovered one, options included. A trailing slash had the same problem on any OS.How did you verify your code works?
Added a test in
supervisor-reload.test.ts: a discovered plugin, configured again with forward slashes, a trailing slash and options. It fails before the change (options missing) and passes after.bun test test/pluginpasses andbun run checkis clean. Tested on Windows 11.Screenshots / recordings
N/A
Checklist