riscv: remove obsolete SFENCE.VM branch from gen_system - #40
Open
carlosqwqqwq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_system()still dispatchesfunct7=0x8/rs2=0x4to the TLB flush helper, implementing theSFENCE.VMinstruction that was removed from the RISC-V privileged architecture in version 1.10. With the defaultPriv1_11configuration ofRiscV64, the encoding0x10400073is retired as a legal instruction instead of raising an illegal-instruction exception.Delete the obsolete branch so the encoding falls into the existing default case and raises
RISCV_EXCP_ILLEGAL_INST.Validation
mcause=2, mepc=0x1018after the fix.SFENCE.VMA x0,x0is unaffected.funct7=0x8/rs2=0x4branch and does not touch SRET/WFI or the CSR paths.Fixes renode/renode#962