Repository navigation
fix(g-lite): createVec3 use nullish coalescing operator - #2245
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
🦋 Changeset detectedLatest commit: d7104b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🟡 Changes recommended
The fixed typed-vector zero-coordinate behavior lacks targeted regression coverage.
1 open finding
What changed in this PR
Fixes zero-valued vector coordinates being incorrectly replaced by fallback values in createVec3.
Changes:
- Uses nullish coalescing for vector coordinates.
- Removes unnecessary Euler conversion casts.
- Adds a patch changeset.
| File | Description |
|---|---|
packages/g-lite/src/utils/math.ts |
Corrects vector fallback behavior and simplifies narrowing. |
.changeset/heavy-berries-greet.md |
Records the patch release. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ? vec3.fromValues(x[0], x[1] ?? y, x[2] ?? z) | ||
| : vec3.set($vec3, x[0], x[1] ?? y, x[2] ?? z); |
|
@kindabit What cases would trigger this difference? |
|
@hustcc when I try to move the center of the graph to the center of viewport, |

🤔 This is a ...
🔗 Related issue link
#2243
☑️ Self Check before Merge