fix: Remove cd side effect when executing pio commands

[kyufie]

Right now, whenever the plugin wants to execute pio commands, cd is performed to move nvim to the project's root. This is not a good approach because it moves the current directory without the user's consent, which affects subsequent terminal spawns and most importantly, things like telescope search.

This change ensures pio commands executed do not affect the global current working directory. I've also improved the project root lookup function to not rely on hardcoded constants.

[anurag3301]

Yeah, I think thats not cool either. I'll review and try your changes and merge it soon

[kyufie]

Thanks.

On a related note, I'm also thinking about using vim.fs.root to perform the project root lookup and vim.system exclusively for the command spawn function. Right now, both helpers still utilize the old API, and those two functions are the modern replacement for them. I wish to change it, but they do require nvim 0.10 which came out two years ago. Let me know if you want to change it.

[dhupee]

@anurag3301 don't put directly to main mate, careful

[anurag3301]

@dhupee yeah I wont, I am yet to test them out. But the recommendation makes sense, what do you think?

[dhupee]

@dhupee yeah I wont, I am yet to test them out. But the recommendation makes sense, what do you think?

Its good imo, coz I remember that the issue also happened to me once a while i just always forgot

Either put to dev branch or i just use Kyufie's branch, in one or two days