Fixed a case where exceptions was not thrown when Tablet closing#6358
Merged
dlmarion merged 1 commit intoapache:2.1from May 5, 2026
Merged
Fixed a case where exceptions was not thrown when Tablet closing#6358dlmarion merged 1 commit intoapache:2.1from
dlmarion merged 1 commit intoapache:2.1from
Conversation
All of the other checks in closeConsistencyCheck throw a RuntimeException, but this check was missing it.
ddanielr
approved these changes
May 4, 2026
Contributor
ddanielr
left a comment
ddanielr
left a comment
There was a problem hiding this comment.
This exception would be caught by the calling code in the if( saveState) block and logged like all the other exceptions. I didn't see any reason why it might have been left off intentionally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the other checks in closeConsistencyCheck throw a RuntimeException, but this check was missing it.