build: make surefire enableProcessChecker overridable for Windows 11 compatibility.#1968
Open
anmol-saxena-14 wants to merge 1 commit intoapache:mainfrom
Open
build: make surefire enableProcessChecker overridable for Windows 11 compatibility.#1968anmol-saxena-14 wants to merge 1 commit intoapache:mainfrom
anmol-saxena-14 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Problem
Surefire 3.x uses
wmicto periodically check whether the parent Maven process is still alive.wmicwas removed in Windows 11 22H2, so the check always fails — the forked test, JVM concludes the parent has died and calls System.exit(1) before any test runs.Symptoms on Windows 11:
[ERROR] The forked VM terminated without properly saying goodbye.
[ERROR] Process Exit Code: 1
## Change
Extract
enableProcessCheckerinto an overridable property with defaultall. Windows 11 developers can now run tests using:mvn test -Dsurefire.enableProcessChecker=ping.No behaviour change for CI or any other environment.
Note:
pinguses the stdin pipe to detect parent-process death rather thanwmic, and works correctly on all platforms.