Skip to content

build: replace Create React App with Vite #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinv8 merged 25 commits into from
Sep 18, 2026
Merged

build: replace Create React App with Vite #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
1fa101f
chore: ignore build output regardless of asset directory depth
xantorres Aug 1, 2026
70e9d29
build: replace Create React App with Vite
xantorres Aug 1, 2026
200b894
refactor: read environment variables through import.meta.env
xantorres Aug 1, 2026
c0e5509
refactor: import diff, semver and image assets as ES modules
xantorres Aug 1, 2026
757fb0f
style: drop tilde prefixes from Sass imports
xantorres Aug 1, 2026
e9943a3
fix: resolve page modules through a statically analyzable import
xantorres Aug 1, 2026
d7391da
fix: parse built asset tags without depending on the emitted format
xantorres Aug 19, 2026
131fc67
build: remove the Create React App toolchain
xantorres Aug 1, 2026
1d51d19
fix: register plugin translations without depending on evaluation order
xantorres Aug 1, 2026
524aadf
chore: drop leftovers from the previous build toolchain
xantorres Aug 1, 2026
b43f089
build: load the build config as a real ES module
xantorres Aug 19, 2026
1252d1a
fix: drop the no-op defer attribute from the module script tag
xantorres Aug 1, 2026
f89b1b7
chore: remove the scaffold test left by the old toolchain
xantorres Aug 1, 2026
0a2270f
fix: emit the bootstrap-icons font files the stylesheet points at
xantorres Aug 2, 2026
d72831a
fix: honor the configured public url in built asset paths
xantorres Aug 2, 2026
949114e
build: check types during the production build
xantorres Aug 2, 2026
df369e8
style: apply the formatter to request.ts
xantorres Aug 2, 2026
26f29bf
build: silence dependency deprecation noise in sass output
xantorres Aug 2, 2026
93462eb
build: keep yaml parsing on the schema the previous loader used
xantorres Aug 2, 2026
2ca0993
fix: serve the module script with the same tag shape the build emits
xantorres Aug 2, 2026
73482a2
build: raise the release workflow Node to the bundler's floor
xantorres Aug 2, 2026
0f881d7
chore: note vite's serve-mode reduction of absolute base urls
xantorres Aug 2, 2026
2cf01e5
build: declare the bundler's real Node support range
xantorres Aug 2, 2026
dc4d65b
build: type the environment variables the app reads
xantorres Aug 2, 2026
6caaa4e
fix: correct malformed custom property in editor background
xantorres Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-binary-for-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: 20.18.1
node-version: 20.19.0

- name: Node Build
run: make install-ui-packages ui
Expand Down
6 changes: 2 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@
/go.work*
/logs
/ui/node_modules
/ui/build/*/*/*
/ui/build/*.json
/ui/build/*.html
/ui/build/*.txt
/ui/build/*
!/ui/build/favicon.ico
/vendor
Thumbs*.db
tmp
Expand Down
1 change: 0 additions & 1 deletion ui/.env.development
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
PUBLIC_URL
REACT_APP_API_URL = http://10.0.20.84:8080/
4 changes: 1 addition & 3 deletions ui/.env.production
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
TSC_COMPILE_ON_ERROR=true
ESLINT_NO_DEV_ERRORS=true
PUBLIC_URL=/
REACT_APP_PUBLIC_URL=/
REACT_APP_API_URL=/
REACT_APP_BASE_URL=
REACT_APP_API_BASE_URL=
1 change: 0 additions & 1 deletion ui/.eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
public
config-overrides.js
commitlint.config.js
build
.eslintrc.js
Expand Down
1 change: 0 additions & 1 deletion ui/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ module.exports = {
es2021: true,
},
extends: [
'react-app/jest',
'plugin:react/recommended',
'airbnb',
'airbnb-typescript',
Expand Down
6 changes: 2 additions & 4 deletions ui/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,8 @@ node_modules

# production

/build/*/*/*
/build/*.json
/build/*.html
/build/*.txt
/build/*
!/build/favicon.ico

# misc
.DS_Store
Expand Down
154 changes: 0 additions & 154 deletions ui/config-overrides.js
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion ui/public/index.html → ui/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1, viewport-fit=cover" />
<meta name="theme-color" />
<meta name="generator" content="Answer - https://github.com/apache/answer">
<link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
<link rel="manifest" href="%BASE_URL%manifest.json" />
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
Expand Down Expand Up @@ -86,6 +86,7 @@
</div>

</div>
<script type="module" src="/src/index.tsx"></script>
</body>
<script>
// disable react devtools
Expand Down
27 changes: 9 additions & 18 deletions ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
"private": true,
"homepage": "/",
"scripts": {
"start": "react-app-rewired start",
"build": "node ./scripts/env.js && react-app-rewired build",
"start": "vite",
"build": "node ./scripts/env.js && tsc --noEmit && vite build",
"preview": "vite preview",
"pre-install": "node ./scripts/importPlugins.js && pnpm install && node ./scripts/preinstall.js ",
"prepare": "pnpm build:packages",
"build:packages": "pnpm -r --filter=./src/plugins/* run build",
Expand Down Expand Up @@ -52,24 +53,18 @@
"devDependencies": {
"@commitlint/cli": "^17.0.3",
"@commitlint/config-conventional": "^17.2.0",
"@fullhuman/postcss-purgecss": "^4.1.3",
"@testing-library/dom": "^8.17.1",
"@testing-library/jest-dom": "^4.2.4",
"@testing-library/react": "^13.3.0",
"@testing-library/user-event": "^13.5.0",
"@modyfi/vite-plugin-yaml": "^1.1.1",
"@types/color": "^3.0.3",
"@types/dompurify": "^2.4.0",
"@types/jest": "^27.5.2",
"@types/lodash": "^4.14.184",
"@types/marked": "^4.0.6",
"@types/node": "^16.11.47",
"@types/node": "^20.19.0",
"@types/qs": "^6.9.7",
"@types/react": "^18.0.17",
"@types/react-dom": "^18.0.6",
"@typescript-eslint/eslint-plugin": "^6.11.0",
"@typescript-eslint/parser": "^6.11.0",
"buffer": "6.0.3",
"customize-cra": "^1.0.0",
"@vitejs/plugin-react": "^6.0.5",
"eslint": "^8.53.0",
"eslint-config-airbnb": "^19.0.4",
"eslint-config-airbnb-typescript": "^17.1.0",
Expand All @@ -85,19 +80,15 @@
"husky": "^9.1.7",
"js-yaml": "^4.1.0",
"lint-staged": "^15.5.0",
"postcss": "^8.0.0",
"prettier": "^3.1.0",
"purgecss-webpack-plugin": "^4.1.3",
"react-app-rewired": "^2.2.1",
"react-scripts": "5.0.1",
"sass": "1.54.4",
"sass": "1.79.6",
"source-map-explorer": "^2.5.3",
"typescript": "^4.9.5",
"yaml-loader": "^0.8.0"
"vite": "^8.2.0"
},
"packageManager": "pnpm@9.7.0",
"engines": {
"node": ">=20",
"node": "^20.19.0 || >=22.12.0",
"pnpm": ">=9"
},
"license": "MIT"
Expand Down
Loading