MINOR: Bump org.apache.hive:hive-storage-api from 4.0.1 to 4.1.0 - #1281
Open
jbonofre wants to merge 1 commit into
Open
MINOR: Bump org.apache.hive:hive-storage-api from 4.0.1 to 4.1.0#1281jbonofre wants to merge 1 commit into
jbonofre wants to merge 1 commit into
Conversation
hive-storage-api 4.2.0 and later are compiled targeting Java 21
(class file major version 65), while this project builds with
maven.compiler.release=17 (major version 61). Using 4.2.x makes the
arrow-orc test compilation fail with:
bad class file: hive-storage-api-4.2.1.jar(.../BytesColumnVector.class)
class file has wrong version 65.0, should be 61.0
4.1.0 is the latest release still targeting Java 17, so bump to that
instead.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1280.
Dependabot proposed bumping
org.apache.hive:hive-storage-apito 4.2.1 in #1280, but that fails the RCBinariesjob:Hive moved its compiler target from Java 17 to Java 21 in 4.2.0, so 4.2.x class files (major version 65) cannot be read by
javac --release 17, which is what this project builds with (maven.compiler.release=17).maven.compiler.target4.1.0 is the newest release still targeting Java 17, so bump to that instead. Once the project raises its baseline to Java 21, 4.2.x becomes viable.
Note that this only surfaces in the RC
Binariesjob:ci/scripts/test.shaddsadapter/orcanddatasetto the reactor only whenARROW_JAVA_JNI=ON, and the Conda JNI jobs run with-DARROW_JAVA_JNI_ENABLE_ORC=OFF.Verification
mvn -Parrow-jni -pl adapter/orc -am test-compileand the same fordatasetboth succeed locally, includingOrcReaderTest, the class that fails on #1280.