aws: use dual-stack endpoints for S3 Express - #828
Open
pdeva wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S3 Express endpoints currently omit the
dualstacklabel. In IPv6-only environments, both session creation and zonal object requests therefore resolve only IPv4 addresses and fail to connect.This change centralizes S3 Express endpoint construction and uses the AWS dual-stack hostname:
The same endpoint feeds both the internal session credential provider and the zonal data client.
Validation:
cargo fmt --all -- --checkcargo test -p object_store --features aws test_s3_express_endpoint