fix: Honor useUnalignedBuffers in ArrowReader.readStreaming#179
Merged
Conversation
readStreaming declared a useUnalignedBuffers parameter and ignored it, hardcoding allowReadingUnalignedBuffers: true when constructing the ByteBuffer. Forward the caller's value instead, matching readFile and fromMessage, which already do so. No new test is included: the flag selects between aligned and unaligned loads inside FlatBuffers and does not change the result of any read on this path, since ByteBuffer(data:) copies the input into aligned storage. A test exercising the parameter would pass with and without this change. Closes apache#177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
readStreamingdeclared auseUnalignedBuffersparameter and ignored it,hardcoding
allowReadingUnalignedBuffers: truewhen constructing theByteBuffer. This forwards the caller's value, matchingreadFileandfromMessage, which already do so.Testing
The full test suite passes with this change.
No new test is included: the flag selects between aligned and unaligned
loads inside FlatBuffers and does not affect the result of any read on this
path, because
ByteBuffer(data:)copies the input into aligned storage. Atest exercising the parameter would pass both with and without this change,
so it would not guard against a regression.
The streaming reader is already covered by
IPCStreamReaderTestsand thestreaming cases in
IPCFileReaderTests.Closes #178.