Repository navigation
GH-48182: [Python] Add regression test for RecordBatch.from_struct_array with list offsets - #49162
Gnananjali wants to merge 2 commits into
Conversation
…uct_array with list offsets
AlenkaF
left a comment
There was a problem hiding this comment.
Thank you for the PR @Gnananjali and sorry for such a late reply.
Everything looks good. I only have one total nit: can we put the tests together with existing ones on test_recordbatch_from_struct_* which are currently starting on line 884:
arrow/python/pyarrow/tests/test_table.py
Line 879 in 892c73d
|
@Gnananjali Thanks for your contribution! :) |
|
Hi! Thank you for following up, and apologies for the delayed response. I only recently noticed the review notifications. I'm definitely interested in continuing this contribution. I'll address Alenka's feedback by moving the test alongside the existing test_recordbatch_from_struct_* tests and push an update. Thank you for your patience! |
|
Thanks for the review! I've moved the test next to the existing |
Adds a regression test to ensure RecordBatch.from_struct_array correctly handles sliced StructArray with offsets.
This test verifies that only the sliced rows are included when converting a StructArray to RecordBatch.
This addresses GH-48182.