GH-25505: [C++][Python] Add replace_with_indices compute kernel - #50809
Open
Kanishk-Dendukuri wants to merge 1 commit into
Open
GH-25505: [C++][Python] Add replace_with_indices compute kernel#50809Kanishk-Dendukuri wants to merge 1 commit into
Kanishk-Dendukuri wants to merge 1 commit into
Conversation
Kanishk-Dendukuri
requested review from
AlenkaF,
pitrou,
raulcd and
rok
as code owners
August 4, 2026 18:32
|
|
github-actions
Bot
added
Component: C++
Component: Python
Component: Documentation
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
replace_with_indices implements a SetItem kernel that overwrites elements of an array at positions given by an integer index array. It is the index based counterpart to the existing mask-based replace_with_mask.
What changes are included in this PR?
New replace_with_indices vector kernel with docs and benchmarks. Replacement i is written to position indices[i]. duplicate indices keep the last write, null indices are ignored, and out of bounds or negative indices raise an error.
Are these changes tested?
Yes. C++ typed tests, randomized cross check against a naive reference, and Python tests.
Are there any user-facing changes?
Yes. Its a new public compute function. No changes to existing functions.
AI Usage
Parts of the code, tests, and this description were written with AI assistance.
Closes #25505