Skip to content

GH-55298: [Python] Support lists of view, decimal32/64 and fixed_size_binary types in to_pandas #55302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
555aaditya wants to merge 1 commit into
base: main
Choose a base branch
from
Open

GH-55298: [Python] Support lists of view, decimal32/64 and fixed_size_binary types in to_pandas #55302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/pyarrow/src/arrow/python/arrow_to_pandas.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,12 +193,17 @@ static inline bool ListTypeSupported(const DataType& type) {
case Type::HALF_FLOAT:
case Type::FLOAT:
case Type::DOUBLE:
case Type::DECIMAL32:
case Type::DECIMAL64:
case Type::DECIMAL128:
case Type::DECIMAL256:
case Type::BINARY:
case Type::LARGE_BINARY:
case Type::BINARY_VIEW:
case Type::FIXED_SIZE_BINARY:
case Type::STRING:
case Type::LARGE_STRING:
case Type::STRING_VIEW:
case Type::DATE32:
case Type::DATE64:
case Type::STRUCT:
Expand Down Expand Up @@ -781,7 +786,8 @@ enable_if_list_like<T, Status> ConvertListsLike(PandasOptions options,
// flattened_values array different.
std::shared_ptr<Array> flattened_values = arr.values()->Slice(
arr.value_offset(0), arr.value_offset(arr.length()) - arr.value_offset(0));
if (arr.value_type()->id() == Type::EXTENSION) {
if (arr.value_type()->id() == Type::EXTENSION &&
!IsUuidExtension(*arr.value_type())) {
const auto& arr_ext = checked_cast<const ExtensionArray&>(*flattened_values);
value_arrays.emplace_back(arr_ext.storage());
} else {
Expand All @@ -792,7 +798,7 @@ enable_if_list_like<T, Status> ConvertListsLike(PandasOptions options,
using ListArrayType = typename ListArrayT::TypeClass;
const auto& list_type = checked_cast<const ListArrayType&>(*data.type());
auto value_type = list_type.value_type();
if (value_type->id() == Type::EXTENSION) {
if (value_type->id() == Type::EXTENSION && !IsUuidExtension(*value_type)) {
value_type = checked_cast<const ExtensionType&>(*value_type).storage_type();
}

Expand Down
13 changes: 13 additions & 0 deletions python/pyarrow/tests/test_extension_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,6 +1454,19 @@ def test_uuid_to_pandas():
)


@pytest.mark.pandas
@pytest.mark.parametrize("list_array_class", [pa.ListArray, pa.LargeListArray])
def test_list_of_uuid_to_pandas(list_array_class):
# GH-55298
import pandas as pd
import pandas.testing as tm
values = [uuid4(), None, uuid4()]
array = list_array_class.from_arrays(
[0, 2, 3, 3], pa.array(values, type=pa.uuid()))
expected = pd.Series([values[:2], values[2:], []])
tm.assert_series_equal(array.to_pandas(), expected)


@pytest.mark.pandas
def test_uuid_to_pandas_options():
values = [uuid4(), uuid4()] * 2
Expand Down
17 changes: 17 additions & 0 deletions python/pyarrow/tests/test_pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,6 +2505,23 @@ def test_large_binary_list(self):
s, pd.Series([["aa", "bb"], None, ["cc"], []]),
check_names=False)

@pytest.mark.parametrize(("value_type", "values"), [
(pa.string_view(), ["aa", None, "bb"]),
(pa.binary_view(), [b"aa", None, b"bb"]),
(pa.binary(2), [b"aa", None, b"bb"]),
(pa.decimal32(3, 1), [decimal.Decimal("1.5"), None, decimal.Decimal("-2.0")]),
(pa.decimal64(3, 1), [decimal.Decimal("1.5"), None, decimal.Decimal("-2.0")]),
])
def test_list_of_view_decimal_and_fixed_size_binary(self, value_type, values):
# GH-55298
expected = [values, None, []]
for list_type_factory in (pa.list_, pa.large_list, pa.list_view):
arr = pa.array(expected, type=list_type_factory(value_type))
tm.assert_series_equal(arr.to_pandas(), pd.Series(expected),
check_names=False)
tm.assert_frame_equal(pa.table({"a": arr}).to_pandas(),
pd.DataFrame({"a": expected}))

def test_list_of_dictionary(self):
child = pa.array(["foo", "bar", None, "foo"]).dictionary_encode()
arr = pa.ListArray.from_arrays([0, 1, 3, 3, 4], child)
Expand Down
Loading