Fix non-unique job names in TextIOReadTest#38242
Fix non-unique job names in TextIOReadTest#38242Subramanya-Veeregowda wants to merge 3 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability of TextIOReadTest by ensuring that job names are unique across test iterations. By dynamically generating distinct job names within the test loop, it prevents potential conflicts that could arise from reusing the same PipelineOptions configuration, thereby ensuring more stable and predictable test execution. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
The failure seems to be due to a transient network issue (HTTP 504 while downloading Gradle). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38242 +/- ##
=============================================
+ Coverage 54.61% 58.51% +3.89%
- Complexity 1689 15430 +13741
=============================================
Files 1067 2851 +1784
Lines 168155 280080 +111925
Branches 1226 12333 +11107
=============================================
+ Hits 91844 163895 +72051
- Misses 74116 109768 +35652
- Partials 2195 6417 +4222
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This PR fixes an issue in "TextIOReadTest" where multiple test iterations were using non-unique job names.
The tests create "PipelineOptions" inside a loop, but the job name was not unique across iterations. This can lead to conflicts or unexpected behavior when running tests.
Updated job name generation to include the loop index along with the timestamp.
Ensures each test execution uses a unique job name.
Improves reliability and isolation of test executions.
No functional changes to production code.
Ran "./gradlew :sdks:java:core:test" locally
All tests pass successfully.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.