Fix GRPC channel leak - #39663
Draft
shunping wants to merge 1 commit into
Draft
Conversation
Abacn
reviewed
Aug 6, 2026
| outboundObserver.onError( | ||
| Status.CANCELLED.withDescription("Multiplexer hanging up").asException()); | ||
| inboundObserver.onCompleted(); | ||
| if (channel != null) { |
Contributor
There was a problem hiding this comment.
Thanks. I was hopping the leak could have resolved in #39390, where BeamFnDataGrpcMultiplexer is closed there. Turns out there are still missing piece here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When running Portable/YAML pipelines, gRPC outputs severe error logs indicating that ManagedChannel instances were garbage collected without being shut down:
Cause
Three places in the Java Fn Harness allocated gRPC ManagedChannel instances without shutting them down upon task completion or harness shutdown: