Firebolt dialect should quote identifiers that need quoting#5106
Merged
Conversation
Contributor
|
I would have liked a Jira ticket for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
No Jira for this one yet. Happy to open a CALCITE issue if you want it tracked.
Changes Proposed
Inverted identifier quoting in the Firebolt dialect
identifierNeedsQuotereturns the regex match, whileExasolSqlDialectandBigQuerySqlDialect, which carry the same regex and the same javadoc, return its negation. Firebolt quotes the identifiers that are already safe unquoted, and emits the ones that are not (spaces,$, backticks, embedded quotes) raw, so an alias carrying a double quote leaves its identifier and the remainder is parsed as SQL rather than as a name.testIdentifieralready pins this behaviour down for the other dialects, so I added Firebolt to it. Before the change that case gives4 AS fo$urand6 AS si`xunquoted. The Firebolt expectations elsewhere in the test were written against the old output and now line up with Exasol, which is the behaviour the regex and the keyword list were there for.