Skip to content

[CALCITE-7774] JDBC adapter generates a GROUP BY with a constant key, which SQL Server rejects #5257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihaibudiu merged 1 commit into from
Sep 16, 2026
+14 −2
Merged

[CALCITE-7774] JDBC adapter generates a GROUP BY with a constant key, which SQL Server rejects #5257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/org/apache/calcite/sql/dialect/MssqlSqlDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,10 @@ private static SqlNode createDatetimeCastSpec(String typeAlias, RelDataType type
return false;
}

@Override public boolean supportsGroupByLiteral() {
return false;
}

@Override public boolean supportsGroupByWithRollup() {
return true;
}
Expand Down
12 changes: 10 additions & 2 deletions core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,9 +590,13 @@ private static RelNode sqlToRel(String sql, SchemaPlus defaultSchema,
+ "(SELECT TRUE AS \"$f0\") AS \"t\"\nGROUP BY \"t\".\"$f0\"";
String expectedInformix = "SELECT AVG(employee.salary)\nFROM foodmart.employee,"
+ "\n(SELECT TRUE AS $f0) AS t\nGROUP BY t.$f0";
String expectedMssql = "SELECT AVG([employee].[salary])\n"
+ "FROM [foodmart].[employee],\n"
+ "(VALUES (1)) AS [t] ([$f0])\nGROUP BY [t].[$f0]";
sql(query)
.withRedshift().ok(expectedRedshift)
.withInformix().ok(expectedInformix);
.withInformix().ok(expectedInformix)
.withMssql().ok(expectedMssql);
}

/** Test case for
Expand Down Expand Up @@ -669,9 +673,13 @@ private static RelNode sqlToRel(String sql, SchemaPlus defaultSchema,
+ "(SELECT DATE '2022-01-01' AS \"$f0\") AS \"t\"\nGROUP BY \"t\".\"$f0\"";
String expectedInformix = "SELECT AVG(employee.salary)\nFROM foodmart.employee,"
+ "\n(SELECT DATE '2022-01-01' AS $f0) AS t\nGROUP BY t.$f0";
String expectedMssql = "SELECT AVG([employee].[salary])\n"
+ "FROM [foodmart].[employee],\n"
+ "(VALUES ('2022-01-01')) AS [t] ([$f0])\nGROUP BY [t].[$f0]";
sql(query)
.withRedshift().ok(expectedRedshift)
.withInformix().ok(expectedInformix);
.withInformix().ok(expectedInformix)
.withMssql().ok(expectedMssql);
}

@Test void testSimpleSelectStarFromProductTable() {
Expand Down
Loading