[CELEBORN-2349] Support worker supplied tags and TagsManager hardening#3719
Open
s0nskar wants to merge 3 commits into
Open
[CELEBORN-2349] Support worker supplied tags and TagsManager hardening#3719s0nskar wants to merge 3 commits into
s0nskar wants to merge 3 commits into
Conversation
Contributor
Author
|
@SteNicholas can you please trigger Copilot magic on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR lets a worker advertise tags at startup and makes tags part of WorkerInfo, so they will use existing Raft replication and worker-lifecycle cleanup. This also gel well with current implementation, allowing tags from config service to be merged with worker supplied tags.
Backward Compatible:
celeborn.tags.worker.registration.enabled(default: true), will allow to ignore worker-supplied tags.Why are the changes needed?
TagsManagertoday only works off the dynamic-config store. There is no way for a worker to declare its own tags. This makes this feature a little hard to use.After this PR a worker can supply its own tags and manage its own tags lifecycle and still allow tags overriding via config service. This will make worker tags feature a lot easier to use.
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?