Fix non-interactive template uploads - #228
dheeraj12347 wants to merge 1 commit into
Conversation
|
Hi @jl0815, @DaanHoogland I’ve opened PR #228 for #227. I traced the non-interactive template upload crash to UploadFiles() dereferencing a nil spinner when HasShell=false. The fix makes spinner handling optional while preserving interactive progress behavior, and I added a regression test that performs an actual multipart upload in non-interactive mode. go test ./..., go vet ./..., and git diff --check all pass. Would appreciate your review when you have time. |
|
✅ Build complete for PR #228. 📦 Binary artifacts are available in the workflow run (expires on October 15, 2026).
|
Summary
Fixes #227.
Template uploads using
filepath=failed in non-interactive mode becauseUploadFiles()unconditionally used the CLI spinner.StartSpinner()returns nil when CloudMonkey is running without a shell,which caused a nil pointer dereference when the spinner was accessed.
This change:
HasShell=falseValidation
go test ./...✅go vet ./...✅git diff --check✅Fixes #227