Deal with Storage Manager tech debt#13598
Quality Gate failed
Failed conditions
Annotations
Check warning on line 3504 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Invoke method(s) only conditionally.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXx&open=AZ9bNmvYu5vY4CaVEhXx&pullRequest=13598
Check failure on line 940 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of duplicating this literal "Failed to add data store: {}" 3 times.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXy&open=AZ9bNmvYu5vY4CaVEhXy&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
No need to call "toString()" method as formatting and string conversion is done by the Formatter.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmrOu5vY4CaVEhXr&open=AZ9bNmrOu5vY4CaVEhXr&pullRequest=13598
Check failure on line 3684 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhX0&open=AZ9bNmvYu5vY4CaVEhX0&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 202 to 64, Complexity from 37 to 14, Nesting Level from 4 to 2, Number of Variables from 40 to 6.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmxmu5vY4CaVEhX2&open=AZ9bNmxmu5vY4CaVEhX2&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
Invoke method(s) only conditionally.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmrOu5vY4CaVEhXq&open=AZ9bNmrOu5vY4CaVEhXq&pullRequest=13598
Check warning on line 433 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Invoke method(s) only conditionally.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXv&open=AZ9bNmvYu5vY4CaVEhXv&pullRequest=13598
Check failure on line 825 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 36 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXz&open=AZ9bNmvYu5vY4CaVEhXz&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 213 to 64, Complexity from 66 to 14, Nesting Level from 4 to 2, Number of Variables from 54 to 6.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmxmu5vY4CaVEhX1&open=AZ9bNmxmu5vY4CaVEhX1&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 176 to 64, Complexity from 59 to 14, Nesting Level from 4 to 2, Number of Variables from 44 to 6.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmxmu5vY4CaVEhX4&open=AZ9bNmxmu5vY4CaVEhX4&pullRequest=13598
Check warning on line 712 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Merge this if statement with the enclosing one.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXs&open=AZ9bNmvYu5vY4CaVEhXs&pullRequest=13598
sonarqubecloud / SonarCloud Code Analysis
A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 153 to 64, Complexity from 49 to 14, Nesting Level from 5 to 2, Number of Variables from 39 to 6.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmxmu5vY4CaVEhX3&open=AZ9bNmxmu5vY4CaVEhX3&pullRequest=13598
Check warning on line 2023 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Merge this if statement with the enclosing one.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXt&open=AZ9bNmvYu5vY4CaVEhXt&pullRequest=13598
Check warning on line 2063 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Merge this if statement with the enclosing one.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXu&open=AZ9bNmvYu5vY4CaVEhXu&pullRequest=13598
Check warning on line 3497 in server/src/main/java/com/cloud/storage/StorageManagerImpl.java
sonarqubecloud / SonarCloud Code Analysis
Invoke method(s) only conditionally.
See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AZ9bNmvYu5vY4CaVEhXw&open=AZ9bNmvYu5vY4CaVEhXw&pullRequest=13598