test: honor skipTests in plugins/storage/volume/ontap/pom.xml#13609
test: honor skipTests in plugins/storage/volume/ontap/pom.xml#13609weizhouapache wants to merge 1 commit into
Conversation
|
this PR is not required if #13578 is merged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13609 +/- ##
=========================================
Coverage 19.50% 19.50%
- Complexity 19438 19441 +3
=========================================
Files 6303 6303
Lines 569288 569288
Branches 69792 69792
=========================================
+ Hits 111028 111034 +6
+ Misses 446106 446100 -6
Partials 12154 12154
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR updates the ONTAP plugin’s Maven test configuration so that the module respects Maven’s standard -DskipTests behavior instead of forcing tests to always run.
Changes:
- Removed the hardcoded Surefire
<skipTests>false</skipTests>override inplugins/storage/volume/ontap/pom.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <configuration> | ||
| <skipTests>false</skipTests> | ||
| <includes> | ||
| <include>**/*Test.java</include> | ||
| </includes> |
Description
This PR fixes the issue that unit tests in
plugins/storage/volume/ontap/are always executed, even if-DskipTestsflag is passed.For users who build the the project with java 21, please pass
-DskipTestsflag, as the unit tests inplugins/storage/volume/ontap/is not compatible with java 21 which will be fixed in next release.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?