UI: expose network ACL replacement from VPC tiers - #13794
Draft
Dogface2k wants to merge 2 commits into
Draft
Conversation
Contributor
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13794 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19788 -4
============================================
Files 6368 6368
Lines 574881 574901 +20
Branches 70351 70352 +1
============================================
- Hits 112970 112946 -24
- Misses 449639 449688 +49
+ Partials 12272 12267 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@Dogface2k |
|
UI build: ✔️ |
Contributor
@weizhouapache there is now also a button in the vpc tiers overview list. I think that is fine as well. (edit: your sshot is from the tiers details page, this is extra) |
Author
|
isolating VPC tier ACL replacement state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Expose the existing
replaceNetworkACLListoperation from the VPC tiers view.Operators can select a tier's replacement ACL, submit the existing typed API action, and receive the normal asynchronous-job result and inventory refresh. The modal is destroyed on close so it does not share a mounted form instance with the create-tier modal.
Scope
replaceNetworkACLListAPI; no server/API changes